GH-45048: [C++][Parquet] Deprecate unused chunk_size parameter in parquet::arrow::FileWriter::NewRowGroup()
#45088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
Component: Python
Component: GLib
awaiting committer review
kszucs
commented
Dec 20, 2024
| @@ -89,10 +89,10 @@ def test_write_table | |||
| def test_write_chunked_array | |||
| schema = build_schema("enabled" => :boolean) | |||
| writer = Parquet::ArrowFileWriter.new(schema, @file.path) | |||
| writer.new_row_group(2) | |||
| writer.new_row_group() | |||
There was a problem hiding this comment.
@kou can we break here as well?
There was a problem hiding this comment.
Yes.
Could you omit () for no argument method call?
Suggested change
| writer.new_row_group() | |
| writer.new_row_group |
github-actions
bot
added
awaiting changes
kszucs
commented
Dec 20, 2024
| @@ -557,6 +557,7 @@ cdef extern from "parquet/arrow/writer.h" namespace "parquet::arrow" nogil: | |||
|
|
|||
| CStatus WriteTable(const CTable& table, int64_t chunk_size) | |||
| CStatus NewRowGroup(int64_t chunk_size) | |||
There was a problem hiding this comment.
@pitrou can we remove the previous signature without deprecation? I assume the pxd files are not widely used.
kou
approved these changes
Dec 20, 2024
| @@ -89,10 +89,10 @@ def test_write_table | |||
| def test_write_chunked_array | |||
| schema = build_schema("enabled" => :boolean) | |||
| writer = Parquet::ArrowFileWriter.new(schema, @file.path) | |||
| writer.new_row_group(2) | |||
| writer.new_row_group() | |||
There was a problem hiding this comment.
Yes.
Could you omit () for no argument method call?
Suggested change
| writer.new_row_group() | |
| writer.new_row_group |
| chunked_array = Arrow::ChunkedArray.new([build_boolean_array([true, nil])]) | ||
| writer.write_chunked_array(chunked_array) | ||
| writer.new_row_group(1) | ||
| writer.new_row_group() |
There was a problem hiding this comment.
Suggested change
| writer.new_row_group() | |
| writer.new_row_group |
github-actions
bot
added
awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Just noticed that the implementation doesn't use the parameter.
What changes are included in this PR?
Remove the parameter from
NewRowGroup()Are these changes tested?
Are there any user-facing changes?
The
chunk_sizeparameter is now deprecated.chunk_sizeparameter inparquet::arrow::FileWriter::NewRowGroup()#45048