GH-14932: [Python] Add python bindings for JSON streaming reader #45084
+402
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pan-x-c
commented
Dec 20, 2024
| assert reader.schema == expected_schema | ||
| assert reader.read_next_batch().to_pydict() == expected_data | ||
|
|
||
| def test_reconcile_across_blocks(self): |
There was a problem hiding this comment.
The original test case in BaseTestJSON.test_reconcile_across_blocks is not compatible with the JSON stream reader.
I made some changes, but I don't know whether this change is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The C++ arrow has a JSON streaming reader which is not exposed on the Python interface.
What changes are included in this PR?
This PR is based on #33761. It adds the
open_jsonmethod to open a streaming reader for a JSON file.Are these changes tested?
Yes
Are there any user-facing changes?
Yes. A new
open_jsonmethod has been added to the Python interface, located atpyarrow.json.open_json, and its parameters are the same as thepyarrow.json.read_json