[AMQ-8354] Add helper methods needed for replica plugin. #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/scheduler/SchedulerBroker.java
Outdated
Show resolved
Hide resolved
| @@ -2387,8 +2495,8 @@ private QueueMessageReference getMatchingMessage(MessageDispatchNotification mes | |||
| messages.reset(); | |||
| while (messages.hasNext()) { | |||
| MessageReference node = messages.next(); | |||
| messages.remove(); | |||
There was a problem hiding this comment.
The idea of this change is to delete only the message that we are looking for. Because deleting all messages up to the one we need prevents reading them in future. Basically if we delete them here, we will not be able to get them anymore.
There was a problem hiding this comment.
And? That's now unneeded change in behaviour
There was a problem hiding this comment.
I am not sure why. this method is used to "deliver" a specific message by id to a specific consumer. we still want to have the access to all other messages. in case we want to "deliver" them too, or in case there is a real consumer
This reverts commit a32ab41.
…r_internal Conflicts: activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java
NikitaShupletsov
force-pushed
the
feature/replica_broker_internal
branch
from
c9c863d
to
e8d92fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMQ-8354
extracted internal changes from #848 to make it easier to review.
Added some new methods that will be used only in replica plugin.
Updated
processDispatchNotificationand related methods to work correctly(it's not been used since pure master-slave feature was deleted). it will also be used in the pluginList of changes:
ConnectionContext#setUserNameto be able to differentiate replication context(the context we use to interact with the broker) from every other to prevent replication of replicated events. ( shouldn't impact the broker)queuePurgedmethod to notify about a queue being purged. needed for queue purge replication. (new method, it shouldn't impact the broker anyhow)getDispatchedmethod to be able to fetch the list of message we are acknowledging, so we can correctly replicate acks(new method, it shouldn't impact the broker anyhow)getMatchingMessagesmethod to be able to get messages by selector when the consumer is full. needed for message compaction(new method, it shouldn't impact the broker anyhow)processDispatchNotification,getMatchingMessageandprocessMessageDispatchNotificationto be able to replicate acks correctly. basically a bug fix. (it's not been used since pure master-slave feature was deleted. it shouldn't impact the broker anyhow)