delays collect::<Vec<_>> until the very end of erasure recovery #4587
+29
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the updated code, we can retain iterators through the call stack and only do collect::<Vec<_>> at the very end.
behzadnouri
force-pushed
the
shred-recover-retain-iter
branch
from
31682ce to
5969c65
Compare
steviez
approved these changes
Jan 23, 2025
| merkle::recover(shreds, reed_solomon_cache)? | ||
| .map(|shred| Ok(Shred::from(shred?))) | ||
| .collect() | ||
| let shreds = merkle::recover(shreds, reed_solomon_cache)?; |
There was a problem hiding this comment.
Outside of scope of this PR - I initially thought we might be able to avoid the collect higher in this function and pass an iterator to merkle::recover(). However, it looks like merkle::recover() needs a sorted list and we need to have all the shreds present in order to sort them, so not sure we can do away with that collect after all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the updated code, we can retain iterators through the call stack and only do
collect::<Vec<_>>at the very end.Summary of Changes
The commit retains iterators through the call stack and only does
collect::<Vec<_>>at the very end of erasure of recovery.