quic: increase timeout and keep alive #4585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrod
previously approved these changes
Jan 22, 2025
lijunwangs
reviewed
Jan 22, 2025
|
Maybe we should different timeout values: stream timeout and idle connection timeout (controlled by the ping) |
lijunwangs
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Quic timeout and keep alive are very low.
When a validator is not leader, it still has thousands of connections open that are not expected to send any data.
Because keep alive is 1s, each client sends a quic ping every second, which is a lot of unnecessary traffic.
Summary of Changes
Increased timeout to 60s and keep alive to 45s.