integrating vortexor with sigverifier #4424
Conversation
vortexor/src/vortexor.rs
Outdated
| // Not interesed of banking tracing | ||
|
|
||
| let verifier = TransactionSigVerifier::new(non_vote_sender); | ||
| SigVerifyStage::new(tpu_receiver, verifier, "solSigVerTpu", "tpu-verifier") |
sigverify integration -- move out sender creation
lijunwangs
force-pushed
the
tpu_vortexor.sigverify.2
branch
from
5ccef5b to
1e581d4
Compare
vortexor/src/vortexor.rs
Outdated
| tpu_receiver: Receiver<solana_perf::packet::PacketBatch>, | ||
| non_vote_sender: TracedSender, | ||
| ) -> SigVerifyStage { | ||
| // Not interesed of banking tracing |
There was a problem hiding this comment.
Also not sure what purpose this comment serves.
| @@ -53,12 +54,19 @@ pub fn main() { | |||
| let max_streams_per_ms = value_t_or_exit!(matches, "max_streams_per_ms", u64); | |||
| let exit = Arc::new(AtomicBool::new(false)); | |||
| // To be linked with the Tpu sigverify and forwarder service | |||
| let (tpu_sender, _tpu_receiver) = unbounded(); | |||
| let (tpu_sender, tpu_receiver) = unbounded(); | |||
There was a problem hiding this comment.
Given that vortexor lives on a different host, would be nice to see some mechanism to control the max size of this queue in case the connection gets stuck. Are you sure we can not use a bounded channel here?
There was a problem hiding this comment.
This was based on the current sig-verify code which uses unbounded channel. I do not think the vortexor on different changes natures regarding this. Sigverfiy is packets from this channel and do the verifications. I think it it changes it may actually be more performant. But I agree with you from defensive programming aspects, if we cannot guarantee the receiver is always faster the the sender, it is good practice to guard against excessive memory usage which could happen under load.
There was a problem hiding this comment.
Will address in a flow-on PR. @alexpyattaev
sigverify integration for vortexor.
Problem
Summary of Changes
sigverify integration for vortexor.
Note the sigverify is only called and the packets sent to the dummy receiver. In next PR we will integrate a sender which will send the verified packets to the Validator side.
Fixes #