Skip to content

Commit

Permalink
Fix missing dependency in solana-curve25519's Cargo.toml (#4301)
Browse files Browse the repository at this point in the history
* Fix missing dependency

* clarify why dep on subtle is needed

Co-authored-by: Jon C <[email protected]>

* add comment about why dependent on subtle

* fix failing CI due to uncommited Cargo.lock changes

* fix failing CI due to trailing whitespace

Co-authored-by: Jon C <[email protected]>

* reorder dependencies

---------

Co-authored-by: Jon C <[email protected]>
  • Loading branch information
hycinth22 and joncinque authored Jan 7, 2025
1 parent e48e123 commit a75585e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions curves/curve25519/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ edition = { workspace = true }
[dependencies]
bytemuck = { workspace = true }
bytemuck_derive = { workspace = true }
# this crate uses `subtle::CtOption<Scalar>::into_option` via curve25519-dalek,
# which requires subtle v2.6.1, but curve25519-dalek only requires v2.3.0
# The line below help users of this crate obtain correct subtle version.
# (that is, the version specified by our workspace or greater minor version, not the version specified by curve25519-dalek)
subtle = { workspace = true }
thiserror = { workspace = true }

[target.'cfg(target_os = "solana")'.dependencies]
Expand Down
1 change: 1 addition & 0 deletions programs/sbf/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions svm/examples/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a75585e

Please sign in to comment.