fix: allParamsOptional implemented in params and props #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
May 8, 2024
|
@Maxim-Mazurok you were recently in there as well want to give these a review? |
Maxim-Mazurok
requested changes
May 8, 2024
There was a problem hiding this comment.
This flag was working as intended, consider updating docs and/or creating a new config flag. See #1322 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Fix #1322
Description
Maybe ensure that 'paramType' isn't already undefined or null). In my view, optional signifies a property marked with a ?, rather than extending the type with| undefined | null.I experimented with these adjustments locally in a playground project using Orval clients: default (axios), vue-query, and Angular.
I have created a draft PR to ensure that my changes pass all the pipeline tests.
These adjustments are to the core, so I hope that by testing them with all the mentioned setups, I have thoroughly validated my changes.
Please feel free to double-check before approving my PR
Related PRs
n/a
Todos
n/a
Steps to Test or Reproduce
n/a