orval/core - generating factory method for schema interfaces #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mironbalcerzak
force-pushed
the
feature/factory-method
branch
from
78b0a4e
to
581b773
Compare
anymaniax
reviewed
Apr 30, 2024
| @@ -53,6 +53,7 @@ export const generateInterface = ({ | |||
| } else { | |||
| model += `export type ${name} = ${scalar.value};\n`; | |||
| } | |||
| model += `export function create${name}(): ${name} ${scalar.factoryMethodValue}\n`; | |||
There was a problem hiding this comment.
You will add this in the model file here. It's a bit weird no?
There was a problem hiding this comment.
Yeah... was thinking whether it should be in separate file or not. I've decided to leave it with model. Anyone who has imported a model, can either instantiate it through "new", or right away call a factory method - which increases the chances that random dev will learn about it and use it.
People are lazy and do not read the code - especially the one that's generated.
|
Hi, @mironbalcerzak |
mironbalcerzak
force-pushed
the
feature/factory-method
branch
4 times, most recently
from
64df5ba
to
76f3ec5
Compare
mironbalcerzak
force-pushed
the
feature/factory-method
branch
from
76f3ec5
to
9e5e347
Compare
mironbalcerzak
force-pushed
the
feature/factory-method
branch
from
9e5e347
to
32e6fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
WIP
Description
Reported enhancement feature ticket #1331
This PR is providing simple implementation.
Opening for discussion.
Bugs? Possible - definitely "stackoverflow" in case of self referencing or cycle
Todos