Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added checks of retrun codes from logitech sdk #2107

Closed
wants to merge 1 commit into from
Closed

added checks of retrun codes from logitech sdk #2107

wants to merge 1 commit into from

Conversation

supergrml
Copy link
Contributor

List any issues that this PR fixes: fixes # , etc...

Fixes: #1953

This pull request proposes the following changes:

  • added an option to deinit and release the LGS/GHub dll
  • check if the sdk functions actually succeed
  • Aurora starting after LGS/Ghub
  • Connection to LGS/GHub lost (program closed/restarted)
  • detaching/reattaching a device

Known issues/To do:

  • when switching profiles in GHub, Ghub sometimes rejects sdk commands

- added an option to deinit and release the LGS/GHub dll
- check if the sdk functions actually succeed

solution for:
- Aurora starting after LGS/Ghub
- Connection to LGS/GHub lost (program closed/restarted)
- detaching/reattaching a device

issue: #1953
@Cheerpipe
Copy link

Cheerpipe commented Jun 23, 2020

Tested with several logitech devies (kb, mice, speakers and mousemat).

It works (randomly) for the keyboard but not for devices that takes more time to be initialized by G HUB.

Test case:

  1. Open G HUB
  2. Open Aurora

Every is working fine so far

  1. Close G HUB

Logitech device stops in Aurora Device Manager

  1. Start G HUB Again

Keyboard is synced with Aurora but mouse and mousemat (speakers some time) are out of sync. Maybe because Logitch SDK is re-loaded before G HUB detects all devices.

@diogotr7
Copy link
Collaborator

I rewrote the logitech integration recently (dev branch), it should have this feature in it. If you notice that it does not work correctly, please submit a new pull request. Aurora seems to detect when LGS is closed (since the Set methods return false when that happens). I think that's what you were trying to solve.

Thanks for bringing this issue to my attention.

@diogotr7 diogotr7 closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants