PHPStan level 9 with bleeding edge #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strings, not floats/ints Also make them a list so adding a new version will make the diff more clear.
…1-8.0" only Tests are executed with GitHub Actions see antonioribeiro#180
spaze
force-pushed
the
spaze/phpstan++
branch
3 times, most recently
from
c5594fe
to
b384d05
Compare
Introduced by yours truly in antonioribeiro#187, sorry. Fix antonioribeiro#192
spaze
force-pushed
the
spaze/phpstan++
branch
5 times, most recently
from
caa76c2
to
ede27ac
Compare
Resolving "Cannot access offset 1 on array|false" on $temp
spaze
force-pushed
the
spaze/phpstan++
branch
from
ede27ac
to
44070e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PHPStan level to 9/max with bleeding edge. You can't go any higher :-) #172 inspired me to do this, to make sure the types are correct throughout the lib.
Native types could be used instead of docblocks if support for older PHP version is dropped, but first I wanted to make sure the lib is on a highest possible PHPStan level to make adding native types a bit safer. Can add them in a next PR once this is merged for example.
This branch is based on #196 branch to make tests run on all PHP versions, probably should be rebased before merging, can take care of that.
I'm not sure what to do with the failing Style CI test that wants me to update a preexisting code like this:
I can update it if it looks like what's expected.