This repository has been archived by the owner on Jan 16, 2023. It is now read-only.
Fix/AWS Multipart Hashes #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-wallace
changed the title
|
Thanks for putting in the work on this! I ran the test suite locally on your branch the the suite is passing. It would be really nice to maintain support for gzip, that should be especially relevant for projects with large files. Is it feasible to make that happen? |
antonagestam
reviewed
Jul 2, 2020
antonagestam
reviewed
Jul 2, 2020
Co-authored-by: Anton Agestam <[email protected]>
sean-wallace
force-pushed
the
fix/aws-multipart-hashes
branch
from
a5385e7
to
2d68cb5
Compare
|
Ok, I think this is ready for another look. Pretty significant changes were necessary to implement the gzip stuff because of the way the Class inheritance is set up. Do you mind if I squash the branch? |
antonagestam
reviewed
Jul 6, 2020
Co-authored-by: Anton Agestam <[email protected]>
…hunks helper function.
Thanks very much for the thoughtful and constructive review -- I've made the changes generally as suggested. Let me know what you think. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first draft of changes to handle hashing multipart uploads to match the ETag on S3. I'm really not sure about the structure of the change, let me know if you'd like it implemented some other way.
I wasn't able to get the live test running locally but I think it should pass. I tested with a project of mine and it seems to work.
Gzip support is not implemented at this point.
Fixes #201