feat: PayPanel component develop #876
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0e809ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 712 717 +5
Lines 21610 21868 +258
Branches 1225 1250 +25
==========================================
+ Hits 21610 21868 +258 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| '@ant-design/web3-assets': patch | |||
There was a problem hiding this comment.
这个也应该是 minor，新增了 type
| * @desc 支持的链虚拟机类型 | ||
| * @descEn Supported chain virtual machine types | ||
| */ | ||
| supportChainTypes?: string[]; |
There was a problem hiding this comment.
这个类型应该是 ChainType 吧，不是 string。
| * @desc 快捷扫码的参数是否支持 | ||
| * @descEn Whether the parameters of fast scan code are supported | ||
| */ | ||
| payQRCodeFormatterFunc?: (params: Record<string, any>) => string; |
There was a problem hiding this comment.
没必要后面再带一个 Func，叫 transferQRCodeFormatter 就好了。
另外 params 要具体定义一下，不要用 Record，有哪些参赛应该是明确的。
| <div className={`${prefixCls}-code-content`}> | ||
| <div className={`${prefixCls}-code-tips`}> | ||
| <InfoCircleOutlined /> | ||
| <span>Please scan the QR code or copy the address</span> |
|
|
||
| const [paymentLink, setPaymentLink] = useState<string>(toAddress); | ||
|
|
||
| const availableWallets = useMemo(() => { |
There was a problem hiding this comment.
这两个 useMemo 感觉都没啥必要，直接算就好了。
| target={{ | ||
| [Mainnet.id]: { | ||
| address: '0x35ceCD3d51Fe9E5AD14ea001475668C5A5e5ea76', | ||
| chain: Mainnet, |
There was a problem hiding this comment.
为啥还要穿 chain？我理解用户传每个链对应的地址就行
| | --- | --- | --- | --- | --- | | ||
| | target | 支持的链及对应的接收地址 | `{ [chainId: string]: { address: string; chain: Chain } }` | - | - | | ||
| | token | Token 的信息 | `Token` | - | - | | ||
| | amount | 指定的数量 | `number \| bigint` | - | - | |
There was a problem hiding this comment.
amount 这个如果传 1 是代表 1 个 USDT 吗？应该是转换后的吧，感觉要写清楚，不然很容易理解错误
|
demo 中的 padding 看上去不太对，留白有点太多了，这个给设计师走查一下吧 
|
图标和文案之间应该有空格 |
其他都有图标，第一个没有，感觉有点不太一致，看看是不是也可以加一个图标 |
选择网络的时候这么素吗？我记得应该还要有一些预估 gas、是否推荐啥的？设计稿什么样的？ |
| return ( | ||
| <Card style={{ width: 450 }}> | ||
| <PayPanel | ||
| target={{ |
There was a problem hiding this comment.
要考虑下实际应用场景，感觉很多情况下地址都是服务端生成的，target 应该要支持下 (chain: Chain) => { address: string };
No description provided.