Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Log control service command #980

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

TheRealHaoLiu
Copy link
Member

do not merge, might leak sensitive information to log need to verify

@TheRealHaoLiu TheRealHaoLiu marked this pull request as draft March 26, 2024 16:30
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@gundalow gundalow changed the title Log control service command [DO NOT MERGE] Log control service command Mar 26, 2024
@@ -274,6 +274,7 @@ func (s *Server) RunControlSession(conn net.Conn) {
if len(cmdBytes) == 0 {
continue
}
s.nc.GetLogger().Debug("Control service received command: %s\n", string(cmdBytes))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to sanitise this to prevent Log Injection Attacks i think.
I have already created SanitizedDebug to do exactly this, however it comes with a performance cost 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants