Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create orgs&teams from auth maps #380

Merged
merged 42 commits into from
May 13, 2024
Merged

create orgs&teams from auth maps #380

merged 42 commits into from
May 13, 2024

Conversation

jctanner
Copy link
Contributor

@jctanner jctanner commented May 8, 2024

No description provided.

@jctanner
Checkin.
e8fe571 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner marked this pull request as draft May 8, 2024 22:13
jctanner added 18 commits May 8, 2024 20:09
@jctanner
Checkin.
a0c0cf2 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Checkin.
5398395 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
We don't always need ALL the orgs and teams.
1f2a795 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Merge branch 'devel' into AAP_23744_CREATE_ORG_TEAM
5573fba
@jctanner
Checkin.
07bda2c 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Unncessary function.
b4bdee2 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Refactor.
7ef4904 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Refactor.
8d2ef3f 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Black formatting.
f2780bf 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Unit tests for get_model functions.
62eaecb 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Checkin.
215e977 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
More tests.
66da691 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Isort fixes.
e6ff23e 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Fix test.
ce78b4d 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Reconcile the claims.
50d1f25 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Flake fixes.
8442f73 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Moar tests.
cadff75 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Lint fixes.
b544dfc 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner marked this pull request as ready for review May 10, 2024 15:54
@jctanner jctanner changed the title [WIP] create orgs&teams from auth maps create orgs&teams from auth maps May 10, 2024
@jctanner
Skip reconciliation if the authenticator's create_objects property is…
7dd41d8 
… false.

No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Update test ...
4ea5ab9 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Negative test.
17207b7 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Lint.
c6e44dd 
No-Issue

Signed-off-by: James Tanner <[email protected]>
cutwater
cutwater requested changes May 10, 2024
View reviewed changes
ansible_base/authentication/utils/claims.py Outdated Show resolved Hide resolved
ansible_base/authentication/utils/claims.py Outdated Show resolved Hide resolved
ansible_base/lib/utils/auth.py Outdated Show resolved Hide resolved
ansible_base/lib/utils/auth.py Outdated Show resolved Hide resolved
ansible_base/lib/utils/auth.py Outdated Show resolved Hide resolved
ansible_base/lib/utils/auth.py Outdated Show resolved Hide resolved
ansible_base/authentication/utils/claims.py Outdated Show resolved Hide resolved
ansible_base/authentication/utils/claims.py Outdated Show resolved Hide resolved
cutwater
cutwater requested changes May 10, 2024
View reviewed changes
ansible_base/authentication/utils/claims.py Outdated Show resolved Hide resolved
ansible_base/authentication/utils/claims.py Outdated Show resolved Hide resolved
@jctanner
Always reconcile.
b2eee06 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Module level imports.
e95137e 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Static method.
35bb67b 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Catch missing orgs&teams during reconcilliation.
dc9c30e 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Catch attrib error.
d458c1c 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Type hinting.
5158284 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
More type hinting.
a948094 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Less fancy.
dc0bbd9 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Oops.
d04fb9a 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Type hinting -everywhere-.
6663986 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner requested a review from cutwater May 12, 2024 22:21
cutwater
cutwater approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@cutwater cutwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we merge this PR, so that I can rebase on top of it and iterate further.

@jctanner
Fix typing hints.
a4b303a 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
More fixes.
b08c3be 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Use Iterable for team names instead of forcing set ...
509886e 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Fix test.
72e5612 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jctanner jctanner merged commit 212664e into ansible:devel May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-westcott-iv john-westcott-iv john-westcott-iv left review comments

@cutwater cutwater cutwater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jctanner @cutwater @john-westcott-iv