Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory option for receptors data #1661

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

AaronH88
Copy link

@AaronH88 AaronH88 commented Dec 5, 2023

SUMMARY

Adding option for setting receptors datadir option which will allow users to set the location of their receptor data. The default is /tmp/receptor/ which may not be the best option for some customers.

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

Tested locally by editing my awx-demo.yml with the following var receptor_datadir under spec

---
apiVersion: awx.ansible.com/v1beta1
kind: AWX
metadata:
  name: awx-demo
spec:
  service_type: nodeport
  receptor_datadir: /tmp/aarontest2/

@AaronH88 AaronH88 marked this pull request as ready for review December 5, 2023 18:18
@@ -889,6 +889,11 @@ spec:
x-descriptors:
- urn:alm:descriptor:com.tectonic.ui:advanced
- urn:alm:descriptor:com.tectonic.ui:hidden
- displayName: Receptor Persistant Data Directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not persistent since /var/run/receptor is an empty dir mount

@@ -458,6 +458,8 @@ host_aliases: ''

receptor_log_level: info

receptor_datadir: /var/run/receptor/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will make it that by default we log into the directory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not logs, but it will make us by default save all the contents of the /tmp/receptor/NODEID/WORKID/* to /var/run/receptor instead

@TheRealHaoLiu
Copy link
Member

what goes into the datadir? is it just the log?

by default on kube i think receptor logs to STDOUT which can be accessed via kubectl log

having a log dir with no rotation can potentially eat up storages

the way that the PR is written there's no way for people to NOT use the datadir

also there's no persistent storage backing the directory which mean that data will be wiped out if the pod is deleted

@AaronH88
Copy link
Author

AaronH88 commented Dec 7, 2023

what goes into the datadir? is it just the log?

by default on kube i think receptor logs to STDOUT which can be accessed via kubectl log

having a log dir with no rotation can potentially eat up storages

the way that the PR is written there's no way for people to NOT use the datadir

also there's no persistent storage backing the directory which mean that data will be wiped out if the pod is deleted

Thanks for the feedback!

The receptor data dir is the location where receptor stores all data it is currently using, as you know (because you taught me) it is currently set to /tmp/receptor/ so the idea here is to make this configurable. I am told some customers would like this 😄

My description on persistent storage is incorrect and I will change it now, thanks for pointing that out.

@TheRealHaoLiu
Copy link
Member

O that tmp dir 🤦‍♂️

The description of the PR mention receptor log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants