Added PodSpec for DNS config,policy and Hostnetwork for rsyslog/redis/ee/task/init and web containers. #1471
Conversation
| type: string | ||
| type: array | ||
| type: object | ||
| rsyslog_dns_Policy: |
There was a problem hiding this comment.
Policy should be lowercase for consistency with the rest here.
|
Is there a particular use case for doing this for Rsyslog? Are you planning to add these fields as configurable for the task/web deployments? |
|
I'm planning to apply for task/web and redis.I will update the PR by end of today |
rakesh561
changed the title
|
@rooftopcellist Updated the PR for all the containers |
rakesh561
force-pushed
the
podspec_dns_config_policy
branch
from
9eae78a
to
dadd514
Compare
| type: string | ||
| task_host_network: | ||
| type: boolean | ||
| init_dns_config: |
There was a problem hiding this comment.
@rakesh561 Is there a use case for having this for the init container? I don't think we should add it if there isn't a scenario that it would be used.
|
@rooftopcellist removed the init container from the config |
fosterseth
force-pushed
the
podspec_dns_config_policy
branch
from
aeead4b
to
643633d
Compare
|
@rakesh561 do you have a podspec(s) that we can use as an example when testing this out locally? also can you please take a look at the above CI failures? |
|
@rakesh561 It looks like CI is failing, before merge a couple things need to happen:
|
…rsyslog and redis deployments
rooftopcellist
force-pushed
the
podspec_dns_config_policy
branch
from
643633d
to
4a70e99
Compare
|
@rakesh561 The CI is failing when applying the task deployment because of an extra closing brace somewhere: |
| {% if ee_dns_policy %} | ||
| dnsPolicy: {{ ee_dns_policy }} | ||
| {% endif %} | ||
| {% if ee_dns_policy == 'None' and ee_dns_config is defined }} |
There was a problem hiding this comment.
@rakesh561 it looks like there is an extra closing brace here at the end of line 350.
| {% if rsyslog_dns_policy %} | ||
| dnsPolicy: {{ rsyslog_dns_policy }} | ||
| {% endif %} | ||
| {% if rsyslog_dns_policy == 'None' and rsyslog_dns_config is defined }} |
There was a problem hiding this comment.
Similarly, there is an extra closing brace at the end of this line too which causes syntax errors when applied.
| {% if redis_dns_policy %} | ||
| dnsPolicy: {{ redis_dns_policy }} | ||
| {% endif %} | ||
| {% if redis_dns_policy == 'None' and redis_dns_config is defined }} |
There was a problem hiding this comment.
Similarly, there is an extra closing brace at the end of this line too which causes syntax errors when applied.
| {% if rsyslog_dns_policy %} | ||
| dnsPolicy: {{ rsyslog_dns_policy }} | ||
| {% endif %} | ||
| {% if rsyslog_dns_policy == 'None' and rsyslog_dns_config is defined }} |
There was a problem hiding this comment.
Similarly, there is an extra closing brace at the end of this line too which causes syntax errors when applied.
| {% if web_dns_policy %} | ||
| dnsPolicy: {{ web_dns_policy }} | ||
| {% endif %} | ||
| {% if web_dns_policy == 'None' and web_dns_config is defined }} |
There was a problem hiding this comment.
Similarly, there is an extra closing brace at the end of this line too which causes syntax errors when applied.
|
@rooftopcellist thanks for finding them i have remove those extra braces |
|
@rooftopcellist let me know wat you think also in between i was off couldn't get back to contribution. |
|
Hi @rakesh561 I think the generic override pattern suggested in #479 is a better way to address your need and a lot more different needs for other people |
|
@rakesh561 try this out it should allow you to override the bits you want |
SUMMARY
Added PodSpec for DNS config,policy and Hostnetwork for rsyslog/redis/ee/task/init and web containers.
ISSUE TYPE
ADDITIONAL INFORMATION
This will address the following #479 issue