Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package_facts add alias support #83149

Merged
merged 9 commits into from May 2, 2024
Merged

package_facts add alias support #83149

merged 9 commits into from May 2, 2024

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 26, 2024

fixes #83143

ISSUE TYPE
  • Feature Pull Request

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 26, 2024
@ansible ansible deleted a comment from ansibot Apr 26, 2024
@ansible ansible deleted a comment from ansibot Apr 26, 2024
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 26, 2024
@ansible ansible deleted a comment from ansibot Apr 26, 2024
Akasurde
Akasurde reviewed Apr 26, 2024
View reviewed changes
lib/ansible/modules/package_facts.py Outdated Show resolved Hide resolved
lib/ansible/modules/package_facts.py Outdated Show resolved Hide resolved
lib/ansible/modules/package_facts.py Outdated Show resolved Hide resolved
lib/ansible/modules/package_facts.py Outdated Show resolved Hide resolved
test/integration/targets/package_facts/tasks/main.yml Outdated Show resolved Hide resolved
bcoca and others added 2 commits April 26, 2024 14:19
@bcoca bcoca marked this pull request as ready for review April 26, 2024 18:19
@webknjaz
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 30, 2024
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 2, 2024
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 2, 2024
@ansible ansible deleted a comment from ansibot May 2, 2024
@bcoca bcoca merged commit ad777cb into ansible:devel May 2, 2024
66 checks passed
@bcoca bcoca deleted the pkg_facts_mgr branch May 2, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. stale_review Updates were made after the last review and the last review is more than 7 days old.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible.builtin.package_facts returns an empty list when manager=auto
5 participants
@bcoca @webknjaz @Akasurde @mkrizek @ansibot