[stable-2.15] facts: Add a generic detection for VMware product name #83109
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use startswith instead of hardcoded values in VMWare product detction Signed-off-by: Abhijeet Kasurde <[email protected]>
ansibot
added
bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
webknjaz
reviewed
Apr 19, 2024
| @@ -176,7 +176,7 @@ def get_virtual_facts(self): | |||
| virtual_facts['virtualization_type'] = 'RHEV' | |||
| found_virt = True | |||
|
|
|||
| if product_name in ('VMware Virtual Platform', 'VMware7,1'): | |||
| if product_name and product_name.startswith(("VMware",)): | |||
There was a problem hiding this comment.
FWIW the passed value doesn't need to be a tuple of strings if there's just one string.
Suggested change
| if product_name and product_name.startswith(("VMware",)): | |
| if product_name and product_name.startswith("VMware"): |
would do the same but looks cleaner
ansibot
removed
the
needs_revision
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
detction
Signed-off-by: Abhijeet Kasurde [email protected]
ISSUE TYPE