Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CredentialType - update Generate extra vars #2194

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

CredentialType - update Generate extra vars #2194

wants to merge 8 commits into from

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Apr 26, 2024 •
edited

Update the dataEditorValue on a value change - so the values set via setValue will show.
Screenshot from 2024-04-26 10-27-41
Screenshot from 2024-04-29 10-25-31

@lgalis lgalis requested a review from jamestalton April 26, 2024 21:05
@github-actions github-actions bot added the AFW Ansible Framework label Apr 26, 2024
@lgalis lgalis marked this pull request as ready for review April 29, 2024 13:15
@lgalis lgalis force-pushed the AAP-22567_update_injector_generator branch from 762984e to 778c263 Compare April 29, 2024 14:02
@lgalis lgalis marked this pull request as draft April 29, 2024 14:04
@lgalis lgalis force-pushed the AAP-22567_update_injector_generator branch from 75f5ad9 to c426f89 Compare April 29, 2024 17:11
@github-actions github-actions bot added EDA Label to indicate changes relevant to EDA CCT Component tests labels Apr 29, 2024
@lgalis lgalis marked this pull request as ready for review April 29, 2024 17:11
@lgalis lgalis requested a review from keithjgrant April 29, 2024 17:11
@lgalis lgalis marked this pull request as draft April 30, 2024 14:54
@lgalis lgalis marked this pull request as ready for review April 30, 2024 18:38
@lgalis lgalis marked this pull request as draft May 1, 2024 12:28
@lgalis lgalis changed the title PageFormDataEditor - Update the dataEditorValue on value change CredentialType - update Generate extra vars May 1, 2024
@lgalis lgalis force-pushed the AAP-22567_update_injector_generator branch from fe81711 to 4f7bba7 Compare May 2, 2024 02:44
@lgalis lgalis force-pushed the AAP-22567_update_injector_generator branch from 4f7bba7 to df8313c Compare May 2, 2024 03:20
@lgalis lgalis marked this pull request as ready for review May 2, 2024 03:28
@mkanoor
Copy link

mkanoor commented May 3, 2024

https://issues.redhat.com/browse/AAP-22567

@appuk
Copy link
Member

appuk commented May 3, 2024

@lgalis Can you please also add the validation for non empty injector configuration? Thanks!

@lgalis lgalis marked this pull request as draft May 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AFW Ansible Framework CCT Component tests EDA Label to indicate changes relevant to EDA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lgalis @mkanoor @appuk