Add support for script filtering with painless #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjl2
reviewed
Dec 6, 2022
|
In terms of security, Elastic has built in security layers to ensure scripts are executed safely. These Elastic docs give a good overview of the layers of security they've implemented. Performance of scripts is going to be mostly case-dependent, as the size of the data queried and amount of computation required can vary widely. Adding support for this feature will not inherently impact the performance of searchkick queries, but writing an inefficient script certainly would. |
nick-galluzzo
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for the
_scriptfilter in Searchkick queries. I would like to add this functionality to support more complex querying cases where the base query language is insufficient.