Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/drag-drop): resolve incompatibility with property minification #28980

Merged
merged 1 commit into from Apr 30, 2024
Merged

fix(cdk/drag-drop): resolve incompatibility with property minification #28980

merged 1 commit into from Apr 30, 2024

Conversation

crisbeto
Copy link
Member

Fixes that the showPopover call was being minified by Closure and preventing the popover from opening.

@crisbeto
fix(cdk/drag-drop): resolve incompatibility with property minification
a82b4de 
Fixes that the `showPopover` call was being minified by Closure and preventing the popover from opening.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 30, 2024
@crisbeto crisbeto added the G This is is related to a Google internal issue label Apr 30, 2024
andrewseguin
andrewseguin approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but surprised this is necessary - isn't this a browser API? I wouldn't expect this function name to be minified

@crisbeto
Copy link
Member Author

I'm a bit surprised as well, but I checked locally that it resolves the issue. My best guess is that typings are outdated somewhere so the compiler didn't know not to minify it.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 30, 2024
@crisbeto crisbeto merged commit 58fa9b7 into angular:main Apr 30, 2024
26 of 29 checks passed
crisbeto added a commit that referenced this pull request Apr 30, 2024
@crisbeto
fix(cdk/drag-drop): resolve incompatibility with property minification (
8e3dfd2 
#28980)

Fixes that the `showPopover` call was being minified by Closure and preventing the popover from opening.

(cherry picked from commit 58fa9b7)
crisbeto added a commit that referenced this pull request Apr 30, 2024
@crisbeto
fix(cdk/drag-drop): resolve incompatibility with property minification (
66afde5 
#28980)

Fixes that the `showPopover` call was being minified by Closure and preventing the popover from opening.

(cherry picked from commit 58fa9b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crisbeto @andrewseguin