Preview popover fixes #28976
Merged
Preview popover fixes #28976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: patch
crisbeto
requested review from
amysorto,
mmalerba,
andrewseguin and
wagnermaciel
crisbeto
force-pushed
the
28974/drag-drop-popover
branch
from
7b2b8bb
to
fd11606
Compare
After angular#28945 the preview is inserted into a `popover` element which has a user agent styling of `color: canvastext`. These changes reset it to `inherit` to match the old behavior. Fixes angular#28974.
crisbeto
force-pushed
the
28974/drag-drop-popover
branch
from
fd11606
to
d99f9f9
Compare
crisbeto
added
the
dev-app preview
|
Deployed dev-app for c356f65 to: https://ng-dev-previews-comp--pr-angular-components-28976-dev-t3fgnong.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
mmalerba
reviewed
Apr 30, 2024
| 'top': '0', | ||
| 'left': '0', | ||
| 'z-index': this._zIndex + '', |
There was a problem hiding this comment.
do we need z-index if its in a popover?
There was a problem hiding this comment.
We still have it, because there's a public API to set it and in case we're running on a browser that doesn't support popovers.
There was a problem hiding this comment.
I think all the browsers we support also support popover, but I guess we can leave it until we deprecate the zindex API
crisbeto
force-pushed
the
28974/drag-drop-popover
branch
from
d99f9f9
to
c356f65
Compare
Switches back to positioning the preview directly instead of using a wrapper which can be breaking for existing apps. Instead we load a stylesheet dynamically with the necessary resets.
crisbeto
removed
the
dev-app preview
crisbeto
force-pushed
the
28974/drag-drop-popover
branch
from
c356f65
to
53fd236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following fixes related the preview popovers:
fix(cdk/drag-drop): reset user agent color on preview popover
After #28945 the preview is inserted into a
popoverelement which has a user agent styling ofcolor: canvastext. These changes reset it toinheritto match the old behavior.fix(cdk/drag-drop): remove preview wrapper
Switches back to positioning the preview directly instead of using a wrapper which can be breaking for existing apps. Instead we load a stylesheet dynamically with the necessary resets.
Fixes #28974.