Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): add documentation for the error NG0955 #55591

Conversation

pkozlowski-opensource
Copy link
Member

This commit adds detailed description for the error NG0955.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2024
@pkozlowski-opensource pkozlowski-opensource added area: core Issues related to the framework runtime area: adev Angular.dev documentation action: review The PR is still awaiting reviews from at least one requested reviewer and removed area: docs Related to the documentation labels Apr 30, 2024
@JeanMeche
Copy link
Member

JeanMeche commented Apr 30, 2024

Could you also the entry to adev/src/content/reference/errors/overview.md and adev/src/app/sub-navigation-data.ts please ? 🙂

@pkozlowski-opensource
Copy link
Member Author

Could you also the entry to adev/src/content/reference/errors/overview.md and adev/src/app/sub-navigation-data.ts please ? 🙂

I could, but ... couldn't we generate this as part of the build? Feels like a manual step that could be automated...

Copy link

github-actions bot commented Apr 30, 2024

Deployed adev-preview for 75ba01c to: https://ng-dev-previews-fw--pr-angular-angular-55591-adev-prev-925r9ghg.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 30, 2024
@pkozlowski-opensource pkozlowski-opensource added the target: rc This PR is targeted for the next release-candidate label Apr 30, 2024
This commit adds detailed description for the errors NG0955 and NG0956.
Those errors correspond to the check introduced in the built-in for loop.
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, angular-dev, public-api

@pullapprove pullapprove bot requested a review from alxhub April 30, 2024 14:52
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit a4a82af.

AndrewKushnir pushed a commit that referenced this pull request Apr 30, 2024
This commit adds detailed description for the errors NG0955 and NG0956.
Those errors correspond to the check introduced in the built-in for loop.

PR Close #55591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: adev Angular.dev documentation area: core Issues related to the framework runtime area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants