Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unescape html entities #55016

Closed
wants to merge 1 commit into from
Closed

Conversation

JeanMeche
Copy link
Member

adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 24, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 24, 2024
Copy link

github-actions bot commented Mar 24, 2024

Deployed adev-preview for 51d2238 to: https://ng-dev-previews-fw--pr-angular-angular-55016-adev-prev-az568lqt.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche marked this pull request as ready for review March 24, 2024 06:46
Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes.

adev/src/content/best-practices/a11y.md Outdated Show resolved Hide resolved
adev/src/content/best-practices/style-guide.md Outdated Show resolved Hide resolved
@sonukapoor sonukapoor self-requested a review March 24, 2024 15:52
adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors.
Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! This is a relief to move away from the escaped characters. Thanks for the PR!

@bencodezen bencodezen added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 25, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Mar 25, 2024

This PR was merged into the repository by commit b2ba945.

dylhunn pushed a commit that referenced this pull request Mar 25, 2024
adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors.

PR Close #55016
@dylhunn dylhunn closed this in b2ba945 Mar 25, 2024
Jefftopia added a commit to Jefftopia/angular that referenced this pull request Mar 26, 2024
transfer cache interceptor should not run again on the client as it is intended for server to client handoff

Squashed commit of the following:

commit 0dbeb44
Merge: a8d132a ee3bb81
Author: Jeffrey Smith <[email protected]>
Date:   Mon Mar 25 17:51:23 2024 -0400

    Merge branch 'main' of https://github.com/angular/angular into feat/skip-transfer-cache-browser

commit ee3bb81
Author: Matthieu Riegler <[email protected]>
Date:   Fri Mar 15 21:27:55 2024 +0100

    refactor(common): request low quality placeholder images (angular#54899)

    For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.

    PR Close angular#54899

commit 13554f9
Author: Alan Agius <[email protected]>
Date:   Thu Mar 21 14:17:03 2024 +0000

    fix(http): manage different body types for caching POST requests (angular#54980)

    This update enhances the encoding handling of request bodies to generate the necessary cache key for transfer cache functionality.

    Closes angular#54956

    PR Close angular#54980

commit b2ba945
Author: Matthieu Riegler <[email protected]>
Date:   Sat Mar 23 23:30:54 2024 -0700

    docs: unescape html entities (angular#55016)

    adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors.

    PR Close angular#55016

commit 9dabef0
Author: Andrea Canciani <[email protected]>
Date:   Sun Mar 24 10:38:34 2024 +0100

    test(zone.js): fix zone.js test listener removal (angular#55017)

    The test was checking the wrong set of listeners because of a typo.

    PR Close angular#55017

commit 6f8b48a
Author: Jeffrey Smith <[email protected]>
Date:   Sat Mar 23 12:29:41 2024 -0400

    feat(common): skip transfer cache on client

    transfer cache interceptor should not run again on the client as it is intended for server to client handoff
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors.

PR Close angular#55016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants