Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adev): change adev inject-based-di link in roadmap.md #54998

Closed
wants to merge 1 commit into from

Conversation

allanbees
Copy link
Contributor

Fix angular.dev roadmap page not found for inject based dependency injection.
Page not found --> https://angular.dev/tutorials/learn-angular/inject-based-di

Fixes 54994.

@pullapprove pullapprove bot requested a review from dylhunn March 22, 2024 12:00
Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change. 👍

@sonukapoor sonukapoor added the area: adev Angular.dev documentation label Mar 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 22, 2024
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 23, 2024
Copy link

Deployed adev-preview for 0f13700 to: https://ng-dev-previews-fw--pr-angular-angular-54998-adev-prev-5r3ojpyf.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@allanbees allanbees changed the title fix: change adev inject-based-di link in roadmap.md docs: change adev inject-based-di link in roadmap.md Mar 27, 2024
@twerske
Copy link
Contributor

twerske commented Mar 27, 2024

Can you change the commit message here? looks like you'd need to add scope to fix(adev): then we can merge!

@allanbees allanbees changed the title docs: change adev inject-based-di link in roadmap.md fix(adev): change adev inject-based-di link in roadmap.md Mar 27, 2024
@allanbees
Copy link
Contributor Author

allanbees commented Mar 27, 2024

Can you change the commit message here? looks like you'd need to add scope to fix(adev): then we can merge!

I changed it. Thanks!

@bencodezen
Copy link
Contributor

Closing this in favor of #54997

@bencodezen bencodezen closed this Mar 28, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: adev Angular.dev documentation target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try out Inject page not found
5 participants