Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resolve extra padding on tutorial editor #54828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bencodezen
Copy link
Contributor

@bencodezen bencodezen commented Mar 12, 2024

As of this commit, there is a visual discrepancy between the height of the content on the left compared to the separator and editors on the right. It appears that the cause of this is an additional computation of layout padding which is unnecessary for these particular elements.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix: CSS styles on docs
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

There is a spacing discrepancy which you can see in the bottom right.

Screenshot 2024-03-12 at 10 12 06 AM (2)

Issue Number: N/A

What is the new behavior?

It will remove the extra padding causing the gap.

Screenshot 2024-03-12 at 10 37 46 AM (2)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

As of this commit, there is a visual discrepancy between the height of the content on the left compared to the separator and editors on the right. It appears that the cause of this is an additional computation of layout padding which is unnecessary for these particular elements.
@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

Deployed adev-preview for 4bcc7ec to: https://ng-dev-previews-fw--pr-angular-angular-54828-adev-prev-s56omp03.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@bencodezen bencodezen added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 13, 2024
@twerske twerske self-requested a review March 26, 2024 22:48
@twerske twerske added target: patch This PR is targeted for the next patch release adev: preview and removed adev: preview labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants