Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain difference between @placeholder and @loading #54779

Closed

Conversation

eluchsinger
Copy link
Contributor

Add a sentence to the @loading block documentation that emphasizes more that the @loading block will replace the @placeholder block once the deferred view starts loading.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #54685

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

google-cla bot commented Mar 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from dylhunn March 8, 2024 15:43
@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 8, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 8, 2024
@JeanMeche
Copy link
Member

Hi, thank you for your contribution, can you have a look at the CLA and sign it ? Thank you.

@eluchsinger eluchsinger force-pushed the docs-defer-placeholder-loading branch from 1638b93 to 61a2453 Compare March 10, 2024 14:59
@eluchsinger
Copy link
Contributor Author

@JeanMeche I have amended the commit with my Email that has the CLA signed.

@bencodezen
Copy link
Contributor

Thanks for the PR @eluchsinger! I submitted a commit to improve the phrasing on the paragraph. Let me know what you think!

@JeanMeche
Copy link
Member

@eluchsinger or @bencodezen can one of you squash the 2 commits ? And we're good to go !

@JeanMeche JeanMeche added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 23, 2024
Add a sentence to the `@loading` block documentation that emphasizes more that the `@loading` block will replace the `@placeholder` block once the deferred view starts loading.
@JeanMeche JeanMeche force-pushed the docs-defer-placeholder-loading branch from 6c3d272 to 85de10d Compare March 26, 2024 17:02
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 26, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Mar 27, 2024

This PR was merged into the repository by commit 9e60609.

@dylhunn dylhunn closed this in 9e60609 Mar 27, 2024
dylhunn pushed a commit that referenced this pull request Mar 27, 2024
Add a sentence to the `@loading` block documentation that emphasizes more that the `@loading` block will replace the `@placeholder` block once the deferred view starts loading.

PR Close #54779
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
…4779)

Add a sentence to the `@loading` block documentation that emphasizes more that the `@loading` block will replace the `@placeholder` block once the deferred view starts loading.

PR Close angular#54779
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants