Skip to content

Commit

Permalink
fix(core): hide implementation details of ExperimentalPendingTasks (#…
Browse files Browse the repository at this point in the history
…55516)

The ExperimentalPendingTasks service was accidently exposing one of its
internal fields as a public one. This commit fixes this by marking the
field in question as private.

PR Close #55516
  • Loading branch information
pkozlowski-opensource authored and AndrewKushnir committed Apr 25, 2024
1 parent 2a3db67 commit 44c0ed8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions goldens/public-api/core/index.md
Expand Up @@ -4,7 +4,6 @@
```ts

import { BehaviorSubject } from 'rxjs';
import { Observable } from 'rxjs';
import { SIGNAL } from '@angular/core/primitives/signals';
import { SignalNode } from '@angular/core/primitives/signals';
Expand Down Expand Up @@ -678,8 +677,6 @@ export interface ExistingSansProvider {
export class ExperimentalPendingTasks {
add(): () => void;
// (undocumented)
internalPendingTasks: ɵPendingTasks;
// (undocumented)
static ɵfac: i0.ɵɵFactoryDeclaration<ExperimentalPendingTasks, never>;
// (undocumented)
static ɵprov: i0.ɵɵInjectableDeclaration<ExperimentalPendingTasks>;
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/pending_tasks.ts
Expand Up @@ -80,7 +80,7 @@ export class PendingTasks implements OnDestroy {
providedIn: 'root',
})
export class ExperimentalPendingTasks {
internalPendingTasks = inject(PendingTasks);
private internalPendingTasks = inject(PendingTasks);
/**
* Adds a new task that should block application's stability.
* @returns A cleanup function that removes a task when called.
Expand Down

0 comments on commit 44c0ed8

Please sign in to comment.