fix(eslint-plugin-template): [attributes-order] Calculate valueless structural directive start/end positions correctly

[bradkovach]

Fixes #1725

• adds edge case unit tests for valueless structural directives
• adds check for valueless structural directive

[bradkovach]

@JamesHenry this could (probably) be merged into branches for prior Angular versions. Do you have a process for that?

As the fixer is potentially destructive, this might be a good thing to incorporate a few versions back.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe82e2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 7 targets

• nx run-many -t e2e-suite --parallel 1
• nx run-many -t test --codeCoverage
• nx run-many -t build,typecheck,check-rule-docs,lint
• nx-cloud record -- yarn format-check
• nx-cloud record -- yarn lint
• nx run-many -t test
• nx run-many -t build

---

Sent with 💌 from NxCloud.

[JamesHenry]

@bradkovach Thanks a lot for this!

Looks like you created this on your main branch and it's blockng me from pushing

You need to please run yarn update-rule-docs and commit the result

[JamesHenry]

See comment

[bradkovach]

Ran the command to update the docs!

[bradkovach]

@JamesHenry i think i got this sorted; do I need to do anything else on my end?

[bradkovach]

@JamesHenry build here failed; looks like an issue with the nx build cache?

[bradkovach]

bump. any updates on this nx cache failure? @JamesHenry

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (8294112) to head (fe82e2c).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
+ Coverage   89.56%   89.71%   +0.14%     
==========================================
  Files         171      176       +5     
  Lines        3202     3287      +85     
  Branches      544      558      +14     
==========================================
+ Hits         2868     2949      +81     
- Misses        198      200       +2     
- Partials      136      138       +2     

Flag	Coverage Δ
unittest	89.71% <ø> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...lint-plugin-template/src/rules/attributes-order.ts	88.23% <ø> (-0.16%)	⬇️
...gin-template/tests/rules/attributes-order/cases.ts	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

[JamesHenry]

Thanks again @bradkovach!