Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Period Switch Ref Update Issue in SSAI Multi-Period Manifest Parsing which leads to crash #1141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lilsax
Copy link

@Lilsax Lilsax commented Feb 29, 2024

This merge request addresses a critical issue in the manifest parsing functionality for the multi-period SSAI manifest, specifically related to period transitions. The problem arises from the failure to update references correctly when encountering a period switch during parsing.

Previously, the parser would generate objects for each period with specific references. However, upon transitioning to a new period, these references were not appropriately updated since it creates a new tracks object with a new reference . Consequently, subsequent attempts to utilize the getStreamIndexToTrackGroupIndex function to retrieve track group information would employ outdated references. As a result, the parser failed to locate the necessary data, leading to application crashes.

To rectify this issue, this merge request introduces a fix that ensures the accurate updating of references during period switches. The fix involves identifying the group index using the track ID, thereby ensuring the retrieval of correct track group information across period transitions.

This enhancement aims to enhance the stability and reliability of the manifest parsing process, preventing crashes and ensuring seamless functionality, particularly during period switches.

@microkatz microkatz self-assigned this Feb 29, 2024
@Lilsax
Copy link
Author

Lilsax commented Mar 8, 2024

Attaching exception screenshot

This is an old screenshot before I fix the error

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants