Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation to InterestScreen from SearchScreen fixed #1416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KarimAly12
Copy link

When users open the search in the Interest screen and search for a non-existing item, they can navigate back to the Interest screen by clicking on "Interests" in the Search screen

Thanks for submitting a pull request. Please include the following information.

What I have done and why
When users open the search in the Interest screen and search for a non-existing item, they can navigate back to the Interest screen by clicking on "Interests" in the Search screen. Before that Interests was navigating back to the interest screen

I used popBackStack() function in onInterestClick(). This will navigate back by removing the search screen from the back of the stack and then navigation to the Interest screen.

Fixes #<1372>

How I'm testing it

Choose at least one:

  • UI tests

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?

When users open the search in the Interest screen and search for a non-existing item, they can navigate back to the Interest screen by clicking on "Interests" in the Search screen
Copy link

google-cla bot commented May 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@KarimAly12 KarimAly12 changed the title BugFixed Navigation_to_InterestScreen_from_SearchScreen May 5, 2024
@KarimAly12 KarimAly12 changed the title Navigation_to_InterestScreen_from_SearchScreen Navigation_to_InterestScreen_from_SearchScreen_Fixed May 5, 2024
@KarimAly12 KarimAly12 changed the title Navigation_to_InterestScreen_from_SearchScreen_Fixed Navigation to InterestScreen from SearchScreen fixed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant