-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For dwjw #156
Open
ekeren
wants to merge
8
commits into
andrewngu:master
Choose a base branch
from
ekeren:for_dwjw
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
For dwjw #156
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1b3023f
fixing sound cloud client id
95b7480
adding Rollout SDK, and configuring flags
83719d0
allowing webpack to run on .amazonaws.com
d6740a4
allowing webpack to run on .rollout.io
6c0ea6e
adding segment to work with rollout impression handler and label
6483de4
setting development (localhost) environment
8ba9635
setup for dwjw
f8a4adc
self managed version
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
// import rox-browser from npm | ||
|
||
import Rox from 'rox-browser' | ||
import UserRepo from '../store/UserRepo' | ||
|
||
// define an exported object that contains the flags | ||
const Flags = { | ||
followingView: new Rox.Flag(), | ||
history: new Rox.Flag(), | ||
shuffle: new Rox.Flag(), | ||
repeat: new Rox.Flag(), | ||
jsonNba: new Rox.Variant('j1', ['j1', 'j2', 'j3']), | ||
startFollowingWord: new Rox.Variant('Follow', ['Follow', 'Start Following', 'Watch Him']) | ||
}; | ||
|
||
// Register the flags object under the namespace "default" | ||
Rox.register('default', Flags); | ||
|
||
|
||
const options = { | ||
|
||
selfManaged: { | ||
serverURL: 'http://localhost:8557', | ||
analyticsURL: 'http://localhost:8558' | ||
} | ||
} | ||
|
||
|
||
// Setup the Rollout key | ||
Rox.setup('5e977711c37225cea474c367', options); | ||
|
||
//Rox.setup('5990c4a1eae09726fa0d6040', { | ||
// devModeSecret: "pFymEevjDCbXWoEZPDqrGT8v" | ||
//}); | ||
|
||
Rox.setCustomStringProperty('plan', () => UserRepo.getUser().plan); | ||
Rox.setCustomStringProperty('email', () => UserRepo.getUser().email); | ||
Rox.setCustomNumberProperty('playlist_count', () => UserRepo.getUser().playlistCount); | ||
Rox.setCustomStringProperty('soundcloud_id', () => UserRepo.getUser().id); | ||
|
||
|
||
//; | ||
export default Flags; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
const UserRepo = { | ||
getUser: () => ({ | ||
plan: "basic", | ||
email: "[email protected]", | ||
playlistCount: 20, | ||
soundcloud_id: "abcd1234" | ||
}) | ||
}; | ||
export default UserRepo; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented code should not be pushed to GitHub.