Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Trakt to use FanartHandler ClearArt paths for Movies #1

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

KJ-Cox
Copy link
Contributor

@KJ-Cox KJ-Cox commented Apr 21, 2024

Utils update to allow MovingPictures to display ClearArt when opened through Trakt Movie categories.

FanartSelectedOther updates:
Aadd IMDBID for Trakt.
Change IsSelectedVideo to false for Trakt movie pages so the ClearArt images don't clear after a movie is selected.
Clear ClearArt images when page navigation selected in Trakt.

This requires MePo update to work.

@KJ-Cox
Copy link
Contributor Author

KJ-Cox commented Apr 22, 2024

Instead of a hack on xml pages to get clearart to work I will add a check for clearart from the xml reader for these values:
#fanarthandler.movie.clearart.selected
#fanarthandler.movie.clearlogo.selected
#fanarthandler.movie.cd.selected
#fanarthandler.series.clearart.selected
#fanarthandler.series.clearlogo.selected

@KJ-Cox
Copy link
Contributor Author

KJ-Cox commented Apr 22, 2024

There is an issue currently getting the #TVSeries.Series.ID value in FanartHandler when using TVSeries plugin. I will investigate tomorrow.

@andrewjswan
Copy link
Owner

andrewjswan commented Apr 22, 2024

private void SetupWindowsUsingFanartHandlerVisibility(string SkinDir = (string) null, string ThemeDir = (string) null)

@andrewjswan
Copy link
Owner

andrewjswan commented Apr 23, 2024

I freed myself up a little and looked at the changes in more detail, I think the comments above will help us complete these changes and improve FH.
FH is made like a chain of dominoes, everything comes down to a single method (Typically in Utils), changes in which will affect the entire FH, and there will be no need to make changes everywhere.

@KJ-Cox
Copy link
Contributor Author

KJ-Cox commented Apr 23, 2024

private void SetupWindowsUsingFanartHandlerVisibility(string SkinDir = (string) null, string ThemeDir = (string) null)

Why are you referencing this function? To read if there is clearart?

@andrewjswan
Copy link
Owner

Why are you referencing this function? To read if there is clearart?

As far as I remember, this function indicates to FH in which windows it is worth looking for Fanart and in which it is not, and you can simply ignore them.

@KJ-Cox
Copy link
Contributor Author

KJ-Cox commented Apr 23, 2024

The function looks for genres, studio and awards. ClearArtMusic might work but will need to test.

@andrewjswan
Copy link
Owner

The function looks for genres, studio and awards. ClearArtMusic might work but will need to test.

We should add by analogy, Music will not work for Movie. Those. you need to do the same but in the Movie section. I could do it, but I don't know when I'll have free time.

@KJ-Cox
Copy link
Contributor Author

KJ-Cox commented Apr 23, 2024

The function looks for genres, studio and awards. ClearArtMusic might work but will need to test.

We should add by analogy, Music will not work for Movie. Those. you need to do the same but in the Movie section. I could do it, but I don't know when I'll have free time.

I am creating the ClearArtMusic now.

@andrewjswan
Copy link
Owner

I am creating the ClearArtMusic now.

Well, it already exists... ???
We don't have enough WindowsUsingFanartSelectedClearArtMovie.

@KJ-Cox
Copy link
Contributor Author

KJ-Cox commented Apr 23, 2024

Sorry, I meant ClearArtMovie. I have created it and tested and it's working.

@andrewjswan
Copy link
Owner

Looks good, I'll make some optimizations, and do a test Build, check, if everything is good, release it.

@andrewjswan andrewjswan merged commit ce13e3a into andrewjswan:master Apr 25, 2024
2 checks passed
andrewjswan added a commit that referenced this pull request Apr 25, 2024
Co-authored-by: KJ-Cox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants