Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ui #77

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feature/ui #77

wants to merge 10 commits into from

Conversation

logiclink
Copy link

Hi,
first of all many thanks for the great plugin.

After working with large keepass databases I missed some UI features. First of all, I wanted to see the password found in the breach. Then, sorting by columns would be great and lastly, I had to copy the data into an excel sheet for further processing of dozens of accounts.
Therefore, I build in the following features:

  1. Set the language version to C# 5 because using features of newer C# version would cause the plugin to be incompatible.
  2. Referenced Keepass.exe to $(MSBuildProgramFiles32)\KeePass Password Safe 2\KeePass.exe which is the default installation path on a x64 windows.
  3. Included a deploy.ps1 PowerShell script which compiles the plugin and copies it into the KeePass plugin folder. It’s a little bit tricky because of the administrative rights you need on a standard windows box – therefore PowerShell with “Start-Process powershell.exe -Verb runAs”.
  4. Added a password column in the BreachedEntriesDialog which is hidden by stars unless you uncheck the checkbox “Hide passwords using asterisk”
  5. Switched from the CustomListViewEx class to a new SortableListView class which enables sorting by clicking on the column headers, allows multi column sorting by pressing shift, shows the current sort direction icons via SendMessage and can copy all selected rows with column headers and the group as first column to the clipboard. It’s a pretty generic approach of sorting, which you can use on other occasions for a windows forms listview.
    I’ve looked at the source of Dominik Reichl’s CustomListViewEx which is a sealed class and couldn’t find any relevant code compared to the standard ListView. Thus, I think the switch to the new class should be ok.
  6. Fixed a small Bug in the double click method of the “Updated to version 1.3.1” commit .
    It would be great if you could include this pull request as it enhances the UI for larger KeePass databases with tens or hundreds of passwords.

I have to confess that – instead of being a software developer since 1996 – this is my first github pull request. Hence, feel free to change the code and contact me for any questions.

Yours,
Marcus

Comment on lines -58 to +60
<HintPath>$(USERPROFILE)\Dropbox\KeePass\KeePass.exe</HintPath>
<HintPath>$(MSBuildProgramFiles32)\KeePass Password Safe 2\KeePass.exe</HintPath>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is changing the hint path intended? It seems like Dropbox would be more common, but I don't know if there's some standard around this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As not all developers might use dropbox I changed the HintPath to the KeePass.exe in default installation folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants