Add Makefile flags to ease building on Cygwin #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the software available for windows user, some flags have been added to make easy and straightforward to build the tool on Cygwin.
Two flags have been added:
O_CYGWINwhich activate building for cygwin.O_LIBXLSXWRITER_ROOTwhich points to the root of thelibxlsxwritercloned project.To link
libxlsxwriter, the makefile is relying on pkg-config to detect if the library is correctly installed, which does not work on cygwin sinceldconfigdoes not exist. Therefore the library should be linked manually. And that is exactly what this PR is enabling.N.B: Guides on how to build on windows environment will be added after the merge.
N.B: The build has been tested on the latest cygwin environment available v3.4.9.