Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local development override option similar to niv #99

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

thillux
Copy link
Contributor

@thillux thillux commented Aug 9, 2024

No description provided.

@thillux thillux marked this pull request as draft August 9, 2024 12:38
@thillux thillux marked this pull request as ready for review August 9, 2024 12:43
@andir
Copy link
Owner

andir commented Aug 12, 2024

Could you write some documentation (at least in the README.md) and add a test for this?

@thillux
Copy link
Contributor Author

thillux commented Aug 12, 2024

Sure (README.md) & I'll try (test).

@thillux
Copy link
Contributor Author

thillux commented Aug 13, 2024

Could you write some documentation (at least in the README.md) and add a test for this?

@andir Both done.

@thillux thillux force-pushed the override branch 2 times, most recently from 35868fe to 18fffb7 Compare August 13, 2024 12:23
@piegamesde
Copy link
Collaborator

What do you think of printing a trace warning for every override so that people don't accidentally run in to it?

@thillux
Copy link
Contributor Author

thillux commented Sep 16, 2024

What do you think of printing a trace warning for every override so that people don't accidentally run in to it?

Done.

@piegamesde piegamesde merged commit 9ba93b1 into andir:master Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants