feat(notification): users receive notifications #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 16, 2017
server/methods/core/orders.js
Outdated
|
|
||
| <h2 style="color: #0099cc; border-bottom: 1px solid grey; padding-bottom: 1%;">Canceled Order</h2> | ||
| <p>Hi,</p> | ||
| <p>Your order of <span style="font-weight: bold;">${order.items.length} item(s)</span> of <span style="color: #0099cc; text-decoration: underline;"><span style="font-weight: bold; text-decoration: none;">id:</span> ${order._id}</span> was canceled. Please find the details below</p> |
There was a problem hiding this comment.
Line 998 exceeds the maximum line length of 160 max-len
server/methods/core/orders.js
Outdated
|
|
||
| <h2 style="color: #0099cc; border-bottom: 1px solid grey; padding-bottom: 1%;">Delivered Order</h2> | ||
| <p>Hi,</p> | ||
| <p>Your order of <span style="font-weight: bold;">${order.items.length} item(s)</span> of <span style="color: #0099cc; text-decoration: underline;"><span style="font-weight: bold; text-decoration: none;">id:</span> ${order._id}</span> has been delivered.</p> |
There was a problem hiding this comment.
Line 519 exceeds the maximum line length of 160 max-len
server/methods/core/orders.js
Outdated
|
|
||
| <h2 style="color: #0099cc; border-bottom: 1px solid grey; padding-bottom: 1%;">Shipping status</h2> | ||
| <p>Hi,</p> | ||
| <p>Your order of <span style="font-weight: bold;">${order.items.length} item(s)</span> of <span style="color: #0099cc; text-decoration: underline;"><span style="font-weight: bold; text-decoration: none;">id:</span> ${order._id}</span> has been packed and would be delivered to you shortly.</p> |
There was a problem hiding this comment.
Line 119 exceeds the maximum line length of 160 max-len
- updated the email sent to users when shipment status changes [finishes #151207884]
fob413
force-pushed
the
feature/151207884/users-notification
branch
from
9dda44d
to
997b6ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notifications for both User and Admin.
Description of Task to be completed?
Notifications are sent to both user and Admin via Email, Sms and In-app when users makes or cancels and order, when admin cancels an order and when shipment status of an order changes
How should this be manually tested?
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/151207884