Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .today() method #1090

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added .today() method #1090

wants to merge 2 commits into from

Conversation

nxtpl
Copy link

@nxtpl nxtpl commented Jul 9, 2018

TLDR:

Added .today() method that resets calendar view to a current date;

Full story:

When using this plugin on a website with multiple calendars, there was a problem - when really old date was picked, the rest calendars remembered it. So it was needed to change the year and month manually. Of course, there is a TODAY button, but users expected a fresh new calendar and submitted forms with wrong dates.
The plugin missed the functionality to reset calendar view only (without removing picked date from input field). To avoid confusion, I named the method .today(), as it don't alter the date field.
Also, added a test case,.

@nxtpl nxtpl mentioned this pull request Jul 9, 2018
@nxtpl
Copy link
Author

nxtpl commented Oct 14, 2019

Hi, will it be integrated into the main version?

@DanielRuf
Copy link
Collaborator

Hi @nxtpl,

We are currently working on v5. You can already try an early v5 version. Can you check if it is missing there?

If so please create a new PR, otherwise we can close this one as resolved.

@DanielRuf
Copy link
Collaborator

Also please do not commit to your master branch and create a separate feature/... branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants