Add overflow buttons to Twitter, Facebook, and Instagram embeds #6502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of ampproject/amphtml#35027, Bento versions of
amp-twitter
,amp-facebook-*
, andamp-instagram
will require anoverflow
button to resize if they are in the initial viewport. This is to prevent these components from negatively impacting CLS, as they do currently. To prevent the need for users to click the overflow button, we'll eventually need to provide the components the required dimensions up-front as much as possible. See #4729.Checklist