Fix new Psalm issues

psalm.xml

@@ -33,5 +33,11 @@
  <directory name="src"/>
  </errorLevel>
  </MissingClosureReturnType>
+
+ <UnsupportedPropertyReferenceUsage>
+ <errorLevel type="suppress">
+ <directory name="src"/>
+ </errorLevel>
+ </UnsupportedPropertyReferenceUsage>
  </issueHandlers>
 </psalm>

src/Internal/Posix/PosixHandle.php

@@ -18,6 +18,7 @@ final class PosixHandle extends ProcessHandle
  /**
  * @param resource $proc Resource from proc_open()
  * @param resource $extraDataPipe Stream resource for exit code
+ * @param positive-int $pid
  */
  public function __construct(
  $proc,

src/Internal/Posix/PosixRunner.php

@@ -120,8 +120,11 @@ static function (CancelledException $e) use ($suspension, $callbackId): void {
  $stdout = new ReadableResourceStream($pipes[1]);
  $stderr = new ReadableResourceStream($pipes[2]);
 
+ $pid = (int) $pid;
+ \assert($pid > 0, 'Expected positive integer for PID');
+
  return new ProcessContext(
- new PosixHandle($proc, (int) $pid, $stdin, $extraDataPipe),
+ new PosixHandle($proc, $pid, $stdin, $extraDataPipe),
  new ProcessStreams($stdin, $stdout, $stderr),
  );
  }

src/Internal/ProcessHandle.php

@@ -20,7 +20,10 @@ abstract class ProcessHandle
 
  public readonly int $originalParentPid;
 
- /** @psalm-suppress PropertyNotSetInConstructor */
+ /**
+ * @psalm-suppress PropertyNotSetInConstructor
+ * @var positive-int
+ */
  public int $pid;
 
  public ProcessStatus $status = ProcessStatus::Starting;

src/Internal/Windows/SocketConnector.php

@@ -204,14 +204,19 @@ public function performClientHandshake($socket): WindowsHandle
  return $handle;
  }
 
+ /**
+ * @return positive-int
+ */
  private function readChildPid(ReadableResourceStream $stream): int
  {
  $packet = \unpack('Csignal/Npid', $this->read($stream, 5));
  if ($packet['signal'] !== SignalCode::CHILD_PID) {
  throw new HandshakeException(HandshakeStatus::SIGNAL_UNEXPECTED);
  }
 
- return (int) $packet['pid'];
+ $pid = (int) $packet['pid'];
+ \assert($pid > 0, 'Expected positive integer for PID');
+ return $pid;
  }
 
  private function readExitCode(ReadableResourceStream $stream): int

src/Process.php

@@ -237,7 +237,7 @@ public function getStderr(): ReadableResourceStream
  * workingDirectory: string,
  * environment: array<string, string>,
  * options: array<string, bool>,
- * pid: positive-int,
+ * pid: int,
  * status: string,
  * }
  */