-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Simplified Agent Installer #1352
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1352 +/- ##
===========================================
- Coverage 82.34% 82.09% -0.25%
===========================================
Files 114 114
Lines 7527 7558 +31
===========================================
+ Hits 6198 6205 +7
- Misses 1329 1353 +24 ☔ View full report in Codecov by Sentry. |
Thanks for starting this, since the linux/mac agents are still in beta they are probably going to change a lot as I am just experimenting with stuff but my plan was to eventually get rid of the bash scripts for installing so this looks like a good start. We're actually working on a contributing guide for both this and the web repo but it's not quite ready yet, so until then I'll just post a snippet from the contributing guide for python specifically, please incorporate this into your PR and lmk if have any questions on them. You can look through the code for examples of all of the below:
# bad
def add_two_numbers(num1, num2):
return num1 + num2 # good
def add_two_numbers(*, num1: int, num2: int) -> int:
return num1 + num2 |
Thanks for the feedback, I'll do my best to incorporate those changes over the next couple of days! |
942055f
to
903a2d6
Compare
The goal of this PR is to update the current agent installer (primarily for linux) to provide a simple command to copy/paste and then run on a remote server without having to copy an installer script around. If this is something of use to the devs, I would like to continue the work here to allow the same functionality on Windows. The macOS install command is pretty close to this already.
Here are the UI changes (provided in a separate PR on the amidaware/tacticalrmm-web repo)