-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape backslashes in search and replacement #592
Open
lens0021
wants to merge
2
commits into
amber-lang:master
Choose a base branch
from
lens0021:replace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wow! Tested and this works. Thanks! 🙌 |
Ph0enixKM
approved these changes
Nov 14, 2024
Mte90
approved these changes
Nov 15, 2024
@lens0021 the tests doesn't work. Can you check what is happening or you need help? |
Mte90
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests does't work
@Mte90 Could you give me some hints please? I could not reproduce the failed tests locally. $ git rev-parse @
946080be7e8c7228d0b448f541b321dbeb4127c8
$ rustc --version
rustc 1.82.0 (f6e511eec 2024-10-15)
$ cargo version
cargo 1.82.0 (8f40fc59f 2024-08-21)
$ rm -rf target
$ cargo build -q
$ cargo test -q
running 223 tests
....................................................................................... 87/223
....................................................................................... 174/223
.................................................
test result: ok. 223 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.02s
$ cargo test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_ext_ab
Finished `test` profile [optimized + debuginfo] target(s) in 0.06s
Running unittests src/main.rs (target/debug/deps/amber-e5eeb9863495dc31)
running 1 test
test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_ext_ab ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 222 filtered out; finished in 0.09s
$ cargo test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_basic_ab
Finished `test` profile [optimized + debuginfo] target(s) in 0.05s
Running unittests src/main.rs (target/debug/deps/amber-e5eeb9863495dc31)
running 1 test
test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_basic_ab ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 222 filtered out; finished in 0.06s
$ cargo test tests::stdlib::test_stdlib_src_tests_stdlib_replace_once_ab
Finished `test` profile [optimized + debuginfo] target(s) in 0.05s
Running unittests src/main.rs (target/debug/deps/amber-e5eeb9863495dc31)
running 1 test
test tests::stdlib::test_stdlib_src_tests_stdlib_replace_once_ab ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 222 filtered out; finished in 0.05s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589.