Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape backslashes in search and replacement #592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lens0021
Copy link

Fixes #589.

@Ph0enixKM
Copy link
Member

Wow! Tested and this works. Thanks! 🙌

@Mte90
Copy link
Member

Mte90 commented Nov 15, 2024

@lens0021 the tests doesn't work. Can you check what is happening or you need help?

Copy link
Member

@Mte90 Mte90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests does't work

@lens0021
Copy link
Author

lens0021 commented Nov 15, 2024

@Mte90 Could you give me some hints please? I could not reproduce the failed tests locally.

$ git rev-parse @
946080be7e8c7228d0b448f541b321dbeb4127c8
$ rustc --version
rustc 1.82.0 (f6e511eec 2024-10-15)
$ cargo version
cargo 1.82.0 (8f40fc59f 2024-08-21)
$ rm -rf target
$ cargo build -q
$ cargo test -q

running 223 tests
....................................................................................... 87/223
....................................................................................... 174/223
.................................................
test result: ok. 223 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.02s

$ cargo test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_ext_ab
    Finished `test` profile [optimized + debuginfo] target(s) in 0.06s
     Running unittests src/main.rs (target/debug/deps/amber-e5eeb9863495dc31)

running 1 test
test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_ext_ab ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 222 filtered out; finished in 0.09s

$ cargo test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_basic_ab
    Finished `test` profile [optimized + debuginfo] target(s) in 0.05s
     Running unittests src/main.rs (target/debug/deps/amber-e5eeb9863495dc31)

running 1 test
test tests::stdlib::test_stdlib_src_tests_stdlib_replace_regex_basic_ab ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 222 filtered out; finished in 0.06s

$ cargo test tests::stdlib::test_stdlib_src_tests_stdlib_replace_once_ab
    Finished `test` profile [optimized + debuginfo] target(s) in 0.05s
     Running unittests src/main.rs (target/debug/deps/amber-e5eeb9863495dc31)

running 1 test
test tests::stdlib::test_stdlib_src_tests_stdlib_replace_once_ab ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 222 filtered out; finished in 0.05s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Standard library replace function fails to replace backslash characters
3 participants