Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/react 18 freezes #266

Merged
merged 7 commits into from
Feb 27, 2023
Merged

Fix/react 18 freezes #266

merged 7 commits into from
Feb 27, 2023

Conversation

saha80
Copy link
Collaborator

@saha80 saha80 commented Feb 24, 2023

Description

Fixes #235

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saha80 saha80 requested a review from leineveber February 24, 2023 16:51
@@ -16,7 +15,15 @@ export const RemoveTagIcon = styled(CloseOutlined)`
cursor: pointer;
`;

export const TagWrapper = styled(TagSpan)`
// https://github.com/rcdexta/react-trello/blob/68cfec88a14312da00a5ca0e1a29bc8de40321d8/src/styles/Base.js#L210
export const TagSpan = styled.span`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused component, can be removed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

tsconfig.json Outdated
"src"
]
}
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's changed in this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leineveber leineveber merged commit 7298444 into develop Feb 27, 2023
@leineveber leineveber deleted the fix/react-18-freezes branch February 27, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants