Add support for ILI9488 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the warnings about RGB565 not being supported via SPI aren't correct. This might only apply to 3 line serial and not 4 line serial. I'll need to check this again before the PR can be merged. |
|
Using the ILI9488 datasheet , on page 119 (3 wire SPI) and page 121 (4 wire spi) it mentions that it supports 3 bit input or 18 bit input. That's why I mentioned it. |
|
I've removed the warning about the color format, because this will be handled by the solution to issue #167. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds official support for the ILI9488. As reported in #158 it did already work by using the ILI9486 code.