Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenAPI Generator #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added OpenAPI Generator #35

wants to merge 2 commits into from

Conversation

mpoimer
Copy link
Contributor

@mpoimer mpoimer commented Apr 8, 2024

No description provided.

#!/bin/bash
cd $(dirname $0)

./APIGeneration/make
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an extra script for the generation? Am I missing something or could this be simplified to one script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it makes sense to have everything generation related in an own folder and this script is just for convenience from the root folder - we can also move everything in here if you want

README.md Outdated
brew install openapi-generator
```

Configuration can be edited in `APIGeneration/generator-config.json`, `APIGeneration/make` and `APIGeneration/.openapi-generator-ignore`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add instructions on how to execute the model generation

@fgeistert
Copy link
Contributor

I think we should also exclude the generated models from the swiftlint step - this can be done in the swiftlint config file

@mpoimer
Copy link
Contributor Author

mpoimer commented Apr 9, 2024

I think we should also exclude the generated models from the swiftlint step - this can be done in the swiftlint config file

@fgeistert
This is already done in the .swiftlint.yml, or am I missing something?

@mpoimer mpoimer requested a review from fgeistert April 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants