Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Route: canary ingress without referrer is valid #100

Merged
merged 2 commits into from
Oct 24, 2023
Merged

HTTP Route: canary ingress without referrer is valid #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc94f9
HTTP Route: canary ingress without referrer is valid
lianglli Oct 24, 2023
0bb2d88
Merge pull request #99 from lianglli/fix-layer7-routes-master
lianglli Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/checksum/ingress/apis/checksum/v1/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ limitations under the License.
// +groupName=tengine.taobao.org

// Package v1 holds api types of version v1 for group "tengine.taobao.org".
package v1 // import "tengine.taobao.org/checksum/ingress/apis/checksum/v1"
package v1 // import "k8s.io/ingress-nginx/internal/checksum/ingress/apis/checksum/v1"
2 changes: 1 addition & 1 deletion internal/checksum/secret/apis/checksum/v1/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ limitations under the License.
// +groupName=tengine.taobao.org

// Package v1 holds api types of version v1 for group "tengine.taobao.org".
package v1 // import "tengine.taobao.org/checksum/secret/apis/checksum/v1"
package v1 // import "k8s.io/ingress-nginx/internal/checksum/secret/apis/checksum/v1"
5 changes: 0 additions & 5 deletions internal/ingress/annotations/canary/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,5 @@ func (c canary) Parse(ing *networking.Ingress) (interface{}, error) {
return nil, errors.NewInvalidAnnotationConfiguration("canary", "configured but not enabled")
}

if config.Enabled && len(config.Referrer) == 0 {
klog.Warningf("Canary ingress[%v/%v] with empty referrer, ignored", ing.Namespace, ing.Name)
return nil, errors.NewInvalidAnnotationConfiguration("canary", "referrer is empty")
}

return config, nil
}