Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useClickAway): callback shouldn't be invoked when a dynamic element inside target is clicked #2530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liuyib
Copy link
Collaborator

@liuyib liuyib commented Apr 24, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #2321

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix(useClickAway): callback shouldn't be invoked when a dynamic element inside target is clicked
🇨🇳 Chinese fix(useClickAway): 点击目标元素内部的动态元素时,不应该调用回调

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@liuyib liuyib requested a review from crazylxr April 24, 2024 08:36
@liuyib
Copy link
Collaborator Author

liuyib commented Apr 25, 2024

这个 PR 的变动单测模拟不出来,按照 #2321 (comment) 的 demo,人工是可以复现出问题,并且这个 PR 确实能解决问题,但是单测里复现不了,所以就没补单测

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useClickAway works wrong
1 participant