fix(trigger): fix a bug it threw an exception at finished step (#581)

* fix(trigger): fix a bug it threw an exception at `finished` step * fix: wrong import paths
algolia · Dec 31, 2019 · eb60e56 · eb60e56
1 parent a32c8dc
commit eb60e56
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/packages/shipjs/src/flow/prepare.js b/packages/shipjs/src/flow/prepare.js
@@ -21,7 +21,7 @@ import createPullRequest from '../step/prepare/createPullRequest';
 import notifyPrepared from '../step/prepare/notifyPrepared';
 import pushToStagingBranch from '../step/prepare/pushToStagingBranch';
 import checkGitHubToken from '../step/checkGitHubToken';
-import finished from '../step/finished';
+import finished from '../step/prepare/finished';
 
 import { print } from '../util';
 import { warning } from '../color';

diff --git a/packages/shipjs/src/flow/release.js b/packages/shipjs/src/flow/release.js
@@ -15,7 +15,7 @@ import gitPush from '../step/release/gitPush';
 import createGitHubRelease from '../step/release/createGitHubRelease';
 import notifyReleaseSuccess from '../step/release/notifyReleaseSuccess';
 import checkGitHubToken from '../step/checkGitHubToken';
-import finished from '../step/finished';
+import finished from '../step/release/finished';
 import { detectYarn } from '../util';
 
 async function release({ help = false, dir = '.', dryRun = false }) {

diff --git a/packages/shipjs/src/step/finished.js → packages/shipjs/src/step/prepare/finished.js b/packages/shipjs/src/step/finished.js → packages/shipjs/src/step/prepare/finished.js
@@ -1,6 +1,6 @@
 import chalk from 'chalk';
-import runStep from './runStep';
-import { print } from '../util';
+import runStep from '../runStep';
+import { print } from '../../util';
 
 export default ({ baseBranch, stagingBranch, pullRequestUrl, dryRun }) =>
   runStep({ title: 'All Finished.' }, () => {

diff --git a/packages/shipjs/src/step/release/finished.js b/packages/shipjs/src/step/release/finished.js
@@ -0,0 +1,3 @@
+import runStep from '../runStep';
+
+export default () => runStep({ title: 'All Finished.' }, () => {});
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import runStep from '../runStep';

		export default () => runStep({ title: 'All Finished.' }, () => {});