fix(helper): don't send empty "tagRefinements" and "facets" parameters #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 131641b:
|
Haroenv
force-pushed
the
feat/map-recommend-results
branch
from
b7755fa
to
828d0cb
Compare
dhayab
force-pushed
the
feat/map-recommend-results
branch
from
828d0cb
to
b9d90b5
Compare
Haroenv
force-pushed
the
fix/prevent-empty-query
branch
2 times, most recently
from
4fe9064
to
8e62b7e
Compare
Haroenv
force-pushed
the
fix/prevent-empty-query
branch
from
8e62b7e
to
131641b
Compare
Haroenv
changed the title
Haroenv
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
dhayab
approved these changes
Jun 18, 2024
| var mainSubResponse = results[0]; | ||
| var mainSubResponse = results[0] || {}; |
There was a problem hiding this comment.
Why should the first response be defaulted?
There was a problem hiding this comment.
this was needed for a previous iteration where it was possible no request was sent if there are no parameters. I reverted that, but this change stayed, as it allows the helper to be a bit more flexible and to be able to instantiate an empty SearchResults if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the first request, we are sending
facets: []andtagRefinements: ''when there are no values for those queries, this isn't needed, and removed in this pull request.This came from an assumption that we could skip queries that have no refinements, but that's not true if you're for example only displaying hits
Result
Slightly more minimal request sent, consistent with the other parameters